Faf client ошибка java

Tried to start FAF client and got this java startup error.
Log;

Exception in Application start method
java.lang.RuntimeException: Exception in Application start method
at javafx.graphics/com.sun.javafx.application.LauncherImpl.launchApplication1(Unknown Source)
at javafx.graphics/com.sun.javafx.application.LauncherImpl.lambda$launchApplication$2(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: com.github.nocatch.NoCatchException: javafx.fxml.LoadException:
file:/D:/Program%20Dosyalar%c4%b1%20(x86)/Downlord’s%20FAF%20Client/lib/downlords-faf-client-0.10.7.jar!/theme/login.fxml

at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
at com.github.nocatch.NoCatch.wrapException(NoCatch.java:61)
at com.github.nocatch.NoCatch.noCatch(NoCatch.java:53)
at com.github.nocatch.NoCatch.noCatch(NoCatch.java:34)
at com.faforever.client.theme.UiService.loadFxml(UiService.java:412)
at com.faforever.client.theme.UiService$$FastClassBySpringCGLIB$$2b0b2208.invoke(<generated>)
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:684)
at com.faforever.client.theme.UiService$$EnhancerBySpringCGLIB$$d9340258.loadFxml(<generated>)
at com.faforever.client.main.MainController.enterLoggedOutState(MainController.java:389)
at com.faforever.client.main.MainController.display(MainController.java:371)
at com.faforever.client.FafClientApplication.showMainWindow(FafClientApplication.java:116)
at com.faforever.client.FafClientApplication.start(FafClientApplication.java:100)
at javafx.graphics/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(Unknown Source)
at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$11(Unknown Source)
at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$9(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
at javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
at javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(Unknown Source)
... 1 more

Caused by: javafx.fxml.LoadException:
file:/D:/Program%20Dosyalar%c4%b1%20(x86)/Downlord’s%20FAF%20Client/lib/downlords-faf-client-0.10.7.jar!/theme/login.fxml

at javafx.fxml/javafx.fxml.FXMLLoader.constructLoadException(Unknown Source)
at javafx.fxml/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at javafx.fxml/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at javafx.fxml/javafx.fxml.FXMLLoader.load(Unknown Source)
at com.github.nocatch.NoCatch.noCatch(NoCatch.java:49)
... 19 more

Caused by: java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.javafx.reflect.Trampoline.invoke(Unknown Source)
at jdk.internal.reflect.GeneratedMethodAccessor22.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at javafx.base/com.sun.javafx.reflect.MethodUtil.invoke(Unknown Source)
at javafx.fxml/com.sun.javafx.fxml.MethodHelper.invoke(Unknown Source)
… 23 more
Caused by: com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:226)
at com.google.gson.Gson.fromJson(Gson.java:927)
at com.google.gson.Gson.fromJson(Gson.java:865)
at com.faforever.client.preferences.PreferencesService.getRemotePreferences(PreferencesService.java:351)
at com.faforever.client.login.LoginController.initialize(LoginController.java:150)
… 33 more
Caused by: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $
at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:385)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:215)
… 37 more

It seems this is the critical part in the code:

I don’t have much Java experience — but I do have some with other languages, and maybe all we need here is to use encode? https://www.geeksforgeeks.org/java-net-urlencoder-class-java/

I gave it a try in a repl, and as expected, the spaces are encoded, but not to «%20«s, instead they turned to «+«es. Which would be fine if the server conformed to url decoding standards, which it seems it doesn’t do, since:

• http://content.faforever.com/mods/Supreme%20Economy%202.2.v0002.zip works, while
• http://content.faforever.com/mods/Supreme+Economy+2.2.v0002.zip doesn’t work, gives 404.

Okay, so I’m onto a bit more hacky solution to do search and replace of white-spaces.

This might do the trick:

System.out.println(URLEncoder.encode(url).replaceAll("+", "%20"));

This way everything is encoded, and we give special consideration to whitespace to be %20 and not +.

Maybe I can try to send in a pull request based on this.

It seems this is the critical part in the code:

I don’t have much Java experience — but I do have some with other languages, and maybe all we need here is to use encode? https://www.geeksforgeeks.org/java-net-urlencoder-class-java/

I gave it a try in a repl, and as expected, the spaces are encoded, but not to «%20«s, instead they turned to «+«es. Which would be fine if the server conformed to url decoding standards, which it seems it doesn’t do, since:

• http://content.faforever.com/mods/Supreme%20Economy%202.2.v0002.zip works, while
• http://content.faforever.com/mods/Supreme+Economy+2.2.v0002.zip doesn’t work, gives 404.

Okay, so I’m onto a bit more hacky solution to do search and replace of white-spaces.

This might do the trick:

System.out.println(URLEncoder.encode(url).replaceAll("+", "%20"));

This way everything is encoded, and we give special consideration to whitespace to be %20 and not +.

Maybe I can try to send in a pull request based on this.

I wanna make a new release of the application but when starting it it throws NoSuchMethodError

java.lang.NoSuchMethodError: com.sun.jna.Native.load(Ljava/lang/String;Ljava/lang/Class;Ljava/util/Map;)Lcom/sun/jna/Library;
    at com.sun.jna.platform.win32.Shell32.<clinit>(Shell32.java:45)
    at com.sun.jna.platform.win32.Shell32Util.getFolderPath(Shell32Util.java:54)
    at com.sun.jna.platform.win32.Shell32Util.getFolderPath(Shell32Util.java:71)
    at com.faforever.client.preferences.PreferencesService.<clinit>(PreferencesService.java:78)
    at com.faforever.client.FafClientApplication.main(FafClientApplication.java:55)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.base/java.lang.reflect.Method.invoke(Unknown Source)
    at com.exe4j.runtime.LauncherEngine.launch(LauncherEngine.java:85)
    at com.exe4j.runtime.WinLauncher.main(WinLauncher.java:94)
    at com.install4j.runtime.launcher.WinLauncher.main(WinLauncher.java:25)

Similar to
NoSuchMethodError using JNA User32 platform map
However I do have version 5.0.0 of both libaries.

It is about this project https://github.com/FAForever/downlords-faf-client it uses gradle as a build tool…

Also I decompiled the installed program and found the method that java claims is not present in the jna libary. Which I find super weird.

Also I check no other dependency has a dependency on jna.

But the thing that is the strangest is it work when I run it all from intelij (oracle jdk 10) but then if I build the installer(openjdk 10 on travis) it does not (same machine).

Also it worked before and we did not change anything about the code related to jna nor the library version. What might have changed is the openjdk version travis uses, but I can not see how that would be related.

Does anybody have an idea what might cause this….

This is the actual code that fails:

Paths.get(Shell32Util.getFolderPath(ShlObj.CSIDL_COMMON_APPDATA), "FAForever")

Even though I thik it is not the problem…

This is the jvm log https://drive.google.com/file/d/11RpxvFubYM7vCoAE-Kx_6EkIKADPQofE/view?usp=sharing

Of which this is probably the important part :

[3.689s][debug][class,resolve               ] com.sun.jna.Native java.lang.Object (super)
[3.689s][debug][class,resolve               ] com.sun.jna.Native com.sun.jna.Version (interface)
[3.689s][debug][class,resolve               ] com.sun.jna.platform.win32.Shell32 com.sun.jna.Native Shell32.java:45 (explicit)
[3.689s][debug][protectiondomain            ] Checking package access
[3.689s][debug][protectiondomain            ] class loader: a 'jdk/internal/loader/ClassLoaders$AppClassLoader'{0x00000000ee70de08} protection domain: a 'java/security/ProtectionDomain'{0x00000000ef103908} loading: 'com/sun/jna/Native'
[3.689s][debug][protectiondomain            ] granted
[3.689s][trace][protectiondomain            ] pd set count = #1
[3.689s][debug][class,resolve               ] com.sun.jna.platform.win32.Shell32 com.sun.jna.Native Shell32.java:45
[3.689s][info ][stacktrace                  ] java.lang.NoSuchMethodError, 12
[3.689s][info ][exceptions                  ] Exception <a 'java/lang/NoSuchMethodError'{0x00000000ef00dd70}: com.sun.jna.Native.load(Ljava/lang/String;Ljava/lang/Class;Ljava/util/Map;)Lcom/sun/jna/Library;> (0x00000000ef00dd70) 
thrown [t:/workspace/open/src/hotspot/share/interpreter/linkResolver.cpp, line 741]
for thread 0x00000000031a5000

Probably the discord library I added also contains jna, see log from jvm:

[3.689s][info ][class,load                  ] com.sun.jna.Native source: file:/E:/DownlordClient%20RC/Downlord's%20FAF%20Client/lib/discord-rpc-1.6.2.jar